This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
add roomnick SlashCommand #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
turt2live
suggested changes
Feb 25, 2019
src/SlashCommands.js
Outdated
| const cli = MatrixClientPeg.get(); | ||
| const ev = cli.getRoom(roomId).currentState.getStateEvents('m.room.member', cli.getUserId()); | ||
| const content = { | ||
| ...ev ? ev.getContent() : null, |
There was a problem hiding this comment.
getContent() will always return an object, however ev may be null (because cache problems) - we should null guard that
There was a problem hiding this comment.
That's what that ternary is doing though, no?
There was a problem hiding this comment.
oh, yup, that's a thing.
There is the scenario where we'd end up sending an event without a membership key though - it should probably always be set to 'join'.
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
…org/matrix-react-sdk into t3chguy/roomnick
turt2live
approved these changes
Feb 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for https://github.com/vector-im/riot-web/issues/2458
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com