This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Report validity state of all registration fields on any change #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation is meant to run in reverse order of the fields (so that the last message emitted is for the first invalid field).
If password confirm is empty on blur, there's no reason to try validating it. The user may just be tabbing through fields.
This passes the validity state of all fields to the consumer of `RegistrationForm` via the `onValdiationChange` callback, instead of just the most recent error. In addition, we notify the consumer for any validation change, whether success or failure. This allows old validation messages to be properly cleared. It also allows the consumer to be aware of multiple validation errors and display the next one after you have fixed the first. Fixes element-hq/element-web#8769
Until we have better validation, let's at least ensure fields with errors are properly marked via color.
turt2live
approved these changes
Feb 22, 2019
| onFormValidationFailed: function(errCode) { | ||
| onFormValidationChange: function(fieldErrors) { | ||
| // Find the first error and show that. | ||
| const errCode = Object.values(fieldErrors).find(value => value); |
There was a problem hiding this comment.
There can be null values for fields without errors, so we need the first non-null one. Maybe !!value or a comment would make it clearer...
There was a problem hiding this comment.
js is also weird and doesn't break on [0] fwiw
> const testArray = [];
undefined
> testArray[0]
undefined
There was a problem hiding this comment.
Ah, but it's not about the values array being empty, but instead the elements in it. For example, the values array might be [null, "bob", null], and we want "bob" here.
There was a problem hiding this comment.
Oh, I see. Yup, that makes sense. A comment would be great :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes the validity state of all fields to the consumer of
RegistrationFormvia theonValdiationChangecallback, instead of just themost recent error.
In addition, we notify the consumer for any validation change, whether success
or failure. This allows old validation messages to be properly cleared. It also
allows the consumer to be aware of multiple validation errors and display the
next one after you have fixed the first.
In addition, this tweaks a few surrounding bits related to validation to ensure bad fields are clearly highlighted in the right order.
Fixes element-hq/element-web#8769