This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Cache-bust languages.json with file-loader #2658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise react-sdk wouldn't be able to build anymore without riot-web in a specific location
2 tasks
bwindels
force-pushed
the
bwindels/moarcachebustin
branch
from
243b170
to
6bf8269
Compare
jryans
approved these changes
Feb 18, 2019
jryans
approved these changes
Feb 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See element-hq/element-web#8710
To get a filename with a content hash in it, we use the file-loader plugin for webpack just like for other resources. But because the file is located in riot-web, we moved the relative path into the webpack config so react-sdk doesn't depend on riot-web directly.