Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Render disabled mxField textareas as disabled #2591

Merged
merged 3 commits into from
Feb 8, 2019

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Feb 7, 2019

.mx_Field input:disabled {
.mx_Field input:disabled,
.mx_Field textarea:disabled,
.mx_Field textarea:disabled + label {
Copy link
Collaborator

@jryans jryans Feb 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styling label as well seems good... but surely we should do the same for select and input labels as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't seem to need to in order to get the disabled effect.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, but for example the theme dropdown's label in Settings doesn't seem disabled...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looked fairly disabled to me :(

I'll double check all the browsers again, and probably flip a table doing it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firefox on macOS looks like:

2019-02-08 at 15 22

which seems to have the label color #454545 (normal) and not #888 (greyed, as would be used here if extended).

@turt2live turt2live requested a review from jryans February 8, 2019 16:53
@turt2live turt2live assigned jryans and unassigned turt2live Feb 8, 2019
@turt2live
Copy link
Member Author

@jryans please take another look. For reference, here's a giant blob of examples:

<Field id={"one"} type={"text"} label={"Enabled Text"}/>
<Field id={"one"} type={"text"} label={"Disabled Text"} disabled={true}/>
<Field id={"one"} type={"text"} label={"Enabled Text"} placeholder={"Enabled text with placeholder"}/>
<Field id={"one"} type={"text"} label={"Disabled Text"} disabled={true} placeholder={"Disabled text with placeholder"}/>
<Field id={"one"} type={"text"} label={"Enabled Text"} value={"with value"}/>
<Field id={"one"} type={"text"} label={"Disabled Text"} disabled={true} value={"with value"}/>

<Field id={"one"} type={"password"} label={"Enabled Password"}/>
<Field id={"one"} type={"password"} label={"Disabled Password"} disabled={true}/>
<Field id={"one"} type={"password"} label={"Enabled Password"} placeholder={"Enabled password with placeholder"}/>
<Field id={"one"} type={"password"} label={"Disabled Password"} disabled={true} placeholder={"Disabled password with placeholder"}/>
<Field id={"one"} type={"password"} label={"Enabled Password"} value={"with value"}/>
<Field id={"one"} type={"password"} label={"Disabled Password"} disabled={true} value={"with value"}/>

<Field id={"one"} element={"textarea"} label={"Enabled Textarea"}/>
<Field id={"one"} element={"textarea"} label={"Disabled Textarea"} disabled={true}/>
<Field id={"one"} element={"textarea"} label={"Enabled Textarea"} placeholder={"Enabled textarea with placeholder"}/>
<Field id={"one"} element={"textarea"} label={"Disabled Textarea"} disabled={true} placeholder={"Disabled textarea with placeholder"}/>
<Field id={"one"} element={"textarea"} label={"Enabled Textarea"} value={"with value"}/>
<Field id={"one"} element={"textarea"} label={"Disabled Textarea"} disabled={true} value={"with value"}/>

<Field id={"one"} element={"select"} label={"Enabled Select"}><option>First Option</option></Field>
<Field id={"one"} element={"select"} label={"Disabled Select"} disabled={true}><option>First Option</option></Field>

image

Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems correct to me, thanks! 😁

@jryans jryans assigned turt2live and unassigned jryans Feb 8, 2019
@turt2live
Copy link
Member Author

I'm merging this because the test breakages are unrelated and I don't want to wait another hour in the CI queue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants