Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix: throttle custom tags updating in LLP #2585

Merged
merged 2 commits into from
Feb 7, 2019

Conversation

bwindels
Copy link
Contributor

@bwindels bwindels commented Feb 7, 2019

No description provided.

@bwindels bwindels requested a review from a team February 7, 2019 15:30
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, and yeah, we can test _.throttle here and if it works, kill off rateLimitedFunction in favour of it. This looks like the behaviour we want.

@@ -17,6 +17,7 @@ import dis from '../dispatcher';
import * as RoomNotifs from '../RoomNotifs';
import RoomListStore from './RoomListStore';
import EventEmitter from 'events';
import * as _ from "lodash";
Copy link
Member

@dbkr dbkr Feb 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have previously imported individual functions from lodash in order to try not to pull in the whole thing (although I suspect webpack 4's tree shaking will remove the rest anyway nowadays, so it probably doesn't make much difference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have previously imported individual functions from lodash in order to try not to pull in the whole thing (although I suspect webpack 4's tree shaking will remove the rest anyway nowadays, so it probably doesn't make much difference.

Ok, changed it anyways 👍

@bwindels
Copy link
Contributor Author

bwindels commented Feb 7, 2019

lgtm, and yeah, we can test _.throttle here and if it works, kill off rateLimitedFunction in favour of it. This looks like the behaviour we want.

Yeah, I'm working to reroute ratelimitedfunc to throttle in another PR as well

@bwindels bwindels merged commit b50bfa1 into develop Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants