Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix: community badges #2581

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Fix: community badges #2581

merged 2 commits into from
Feb 7, 2019

Conversation

bwindels
Copy link
Contributor

@bwindels bwindels commented Feb 7, 2019

Don't assume a user has joined all the rooms in a community

@bwindels bwindels requested a review from a team February 7, 2019 12:12
@ara4n
Copy link
Member

ara4n commented Feb 7, 2019

personally i prefer an explicit check (e.g. !== null or !== undefined) than !!r but otherwise lgtm

@bwindels
Copy link
Contributor Author

bwindels commented Feb 7, 2019

personally i prefer an explicit check (e.g. !== null or !== undefined) than !!r but otherwise lgtm

Checking for both just in case getRoom starts returning undefined instead of null at some point in the future.

@bwindels bwindels merged commit 7affcf7 into develop Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants