This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Make auth validation less annoying #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwindels
approved these changes
Jan 31, 2019
`hsName` uses only the default HS, so that can easily be outdated if the HS URL is customized.
jryans
force-pushed
the
auth-less-annoying
branch
2 times, most recently
from
f8a578f
to
346f73b
Compare
This was referenced Jan 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick pass to make authentication validation less annoying in the current world before fancy tooltips arrive.
Some highlights include:
Fixes element-hq/element-web#8293.
Watch as I tab through fields without anything scary happening: