Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

redesign: small fixes #2520

Merged
merged 8 commits into from
Jan 29, 2019
Merged

redesign: small fixes #2520

merged 8 commits into from
Jan 29, 2019

Conversation

this was caused by the layout growing wider than it could,
hence the overflow event being triggered.

The overflow event is only supported in FF and we fire the
manual check often enough that the overflow gradient still
reliably (dis)appears when needed.
@bwindels bwindels changed the title Bwindels/redesign smallfixes redesign: small fixes Jan 29, 2019
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

Edit: I didn't realize this had the notready label, sorry. I swear it came through as review requested ._.

@@ -1497,5 +1497,6 @@
"If you didn't remove the recovery method, an attacker may be trying to access your account. Change your account password and set a new recovery method immediately in Settings.": "If you didn't remove the recovery method, an attacker may be trying to access your account. Change your account password and set a new recovery method immediately in Settings.",
"Failed to set direct chat tag": "Failed to set direct chat tag",
"Failed to remove tag %(tagName)s from room": "Failed to remove tag %(tagName)s from room",
"Failed to add tag %(tagName)s to room": "Failed to add tag %(tagName)s to room"
"Failed to add tag %(tagName)s to room": "Failed to add tag %(tagName)s to room",
"Guest": "Guest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use npm run i18n to maintain the ordering of the file (unless this is really lucky to be at the end?)

@bwindels bwindels merged commit 8e7f3e1 into experimental Jan 29, 2019
@bwindels bwindels removed the notready label Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants