Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix cancelling dialog boxes by clicking on the background #232

Merged
merged 4 commits into from
Mar 18, 2016
Merged

Fix cancelling dialog boxes by clicking on the background #232

merged 4 commits into from
Mar 18, 2016

Commits on Mar 18, 2016

  1. remove totally dead wood from stale Modal API

    @ara4n
    ara4n committed Mar 18, 2016
    Configuration menu
    Copy the full SHA
    d0d2213 View commit details
    Browse the repository at this point in the history

  2. ensure we call onFinished successfully if the user actually hits submit

    @ara4n
    ara4n committed Mar 18, 2016
    Configuration menu
    Copy the full SHA
    e63990a View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary Modal.createDialogWithElement, complete with its b… 

    …roken onFinished() support. Switch SetDisplayNameDialog to use Modal.createDialog(). Explicitly pass false to closeDialog if the user tries to cancel dialogs by clicking on the background, rather than passing in an event object which evaluates to true.
    @ara4n
    ara4n committed Mar 18, 2016
    Configuration menu
    Copy the full SHA
    deaa5c3 View commit details
    Browse the repository at this point in the history

  4. fix proptypes on dialogs

    @ara4n
    ara4n committed Mar 18, 2016
    Configuration menu
    Copy the full SHA
    03bdcf2 View commit details
    Browse the repository at this point in the history