Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

click on nicks to insert them into the MessageComposer #230

Merged
merged 5 commits into from
Mar 17, 2016

Conversation

ara4n
Copy link
Member

@ara4n ara4n commented Mar 17, 2016

No description provided.

@ara4n ara4n assigned richvdh and unassigned richvdh Mar 17, 2016
@ara4n
Copy link
Member Author

ara4n commented Mar 17, 2016

oops, i missed something; one sec

@ara4n
Copy link
Member Author

ara4n commented Mar 17, 2016

right, focus sorted now - this pairs nicely with a glass of fine 1963 element-hq/element-web#1191

</div>
);
}
if (EventTileType.needsSenderProfile()) {
sender = <SenderProfile mxEvent={this.props.mxEvent} aux={aux} />;
sender = <SenderProfile onClick={ this.onSenderProfileClick } mxEvent={this.props.mxEvent} aux={aux} />;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an associated vector-web change to add an onClick property to SenderProfile?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, see main PR comment stream

@richvdh richvdh assigned ara4n and unassigned richvdh Mar 17, 2016
@ara4n
Copy link
Member Author

ara4n commented Mar 17, 2016

@richvdh PTAL

@ara4n ara4n assigned richvdh and unassigned ara4n Mar 17, 2016
@richvdh
Copy link
Member

richvdh commented Mar 17, 2016

lgtm

@richvdh richvdh assigned ara4n and unassigned richvdh Mar 17, 2016
ara4n added a commit that referenced this pull request Mar 17, 2016
click on nicks to insert them into the MessageComposer
@ara4n ara4n merged commit cbf0349 into develop Mar 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants