This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Redesign: use native auto-hiding scrollbars in room sub lists #2264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shows scrollbar on hover when needed has fallback to overflow: overlay and fiddling with padding to make content not jump on hover.
dbkr
approved these changes
Nov 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
element-hq/element-web#7560
As gemini scrollbars cause lag while resizing and have some layout implications for the room lists distribution, I had a go at using native scrollbars. I just applied it to the room sub lists, but could be expanded to the whole app.
The idea is put it on experimental and have people play around with it to see if we like it.
Browser support is organized in 3 tiers:
overflow: auto. This includes Edge with-ms-overflow-style: -ms-autohiding-scrollbar. (Safari, Edge, others depending on platform)overflow: overlay. This does not auto-hide the scrollbars however, so need to only do that on hover. (Chrome anywhere).overflow/underflowevents to add/remove css classes so CSS is aware of overflow. These events are Firefox only, but we already have all the other supported browsers covered with the prior approaches.