This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Update to new version of slate #2202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of fixes here as a lot of the API has changed (eg. anchorKey / offsetKey are now anchor.key and offset.key, and collapseFocusToThing is moveFocusToThing). Also changes the ref to a function (sorry for lumping this into the same PR). Hopefully will fix element-hq/element-web#7105
Closed
We already have it above
For some reason the slate update means the composer doesn't have the focus after closing the room settings, and the end to end tests pick this up!
turt2live
approved these changes
Oct 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of fixes here as a lot of the API has changed (eg. anchorKey /
offsetKey are now anchor.key and offset.key, and collapseFocusToThing
is moveFocusToThing).
Also changes the ref to a function (sorry for lumping this into the
same PR).
Hopefully will fix element-hq/element-web#7105
Presumably fixes element-hq/element-web#7419