Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Provide more helpful errors when i18n generation fails #2181

Merged
merged 1 commit into from
Sep 27, 2018

Conversation

turt2live
Copy link
Member

Also fix TextForEvent.js so it doesn't break the script. Using a variable here is not recognized, so the object has been moved inline instead.

Also fix TextForEvent.js so it doesn't break the script. Using a variable here is not recognized, so the object has been moved inline instead.
@turt2live turt2live requested a review from a team September 27, 2018 17:57
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the same thing this week but forgot to make a PR out of it :)

@turt2live
Copy link
Member Author

For future people, the exception encountered was:

ERROR: src\TextForEvent.js:236 %(senderName)s added %(addedAddresses)s and removed %(removedAddresses)s as addresses for this room.
TypeError: obj.properties is not iterable
    at getObjectValue (C:\Git-updated\_workspaces\riot-web\matrix-react-sdk\scripts\gen-i18n.js:56:28)
    at Object.enter (C:\Git-updated\_workspaces\riot-web\matrix-react-sdk\scripts\gen-i18n.js:137:43)
    at visit (C:\Git-updated\_workspaces\riot-web\matrix-react-sdk\node_modules\estree-walker\dist\estree-walker.umd.js:31:9)
    at visit (C:\Git-updated\_workspaces\riot-web\matrix-react-sdk\node_modules\estree-walker\dist\estree-walker.umd.js:53:4)
    at visit (C:\Git-updated\_workspaces\riot-web\matrix-react-sdk\node_modules\estree-walker\dist\estree-walker.umd.js:48:5)
    at visit (C:\Git-updated\_workspaces\riot-web\matrix-react-sdk\node_modules\estree-walker\dist\estree-walker.umd.js:53:4)
    at visit (C:\Git-updated\_workspaces\riot-web\matrix-react-sdk\node_modules\estree-walker\dist\estree-walker.umd.js:53:4)
    at visit (C:\Git-updated\_workspaces\riot-web\matrix-react-sdk\node_modules\estree-walker\dist\estree-walker.umd.js:48:5)
    at visit (C:\Git-updated\_workspaces\riot-web\matrix-react-sdk\node_modules\estree-walker\dist\estree-walker.umd.js:53:4)
    at visit (C:\Git-updated\_workspaces\riot-web\matrix-react-sdk\node_modules\estree-walker\dist\estree-walker.umd.js:48:5)

@turt2live turt2live merged commit cf0c12f into develop Sep 27, 2018
@turt2live turt2live deleted the travis/fix-i18n-script-1 branch September 27, 2018 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants