Online incremental megolm backups (v2) #2169
Conversation
Continues from Matthew's work: adds a feature flag & panel in user settings to create a backup. Can't restore a backup yet, nor even continue backing up to the same backup after a refresh.
Didn't end up using it for this iteration
dbkr
changed the title
| * Walks the user through the process of creating an e22 key backup | ||
| * on the server. | ||
| */ | ||
| export default React.createClass({ |
There was a problem hiding this comment.
i don't suggest we change this one, but surely we should be creating new stuff as ES6 at last given the language caught up (and React 16 mandates it?)
There was a problem hiding this comment.
Yeah, I guess we should update the code style as I don't think we have
| phase: PHASE_GENERATING, | ||
| }); | ||
| // Look, work is being done! | ||
| await Promise.delay(1200); |
There was a problem hiding this comment.
okay, i'm totally missing why we'd want a pregnant pause at this point
There was a problem hiding this comment.
This was me making it look like it's doing something to help the user understand the key is being generated rather than just shown to you, which it sort of des if it comes up instantly. Given it's all temporary UI I thought I'd experiment. :)
There was a problem hiding this comment.
There was a problem hiding this comment.
ok. might be worth adding the rationale - i.e. to fake a generation
src/components/views/dialogs/keybackup/RestoreKeyBackupDialog.js
Outdated
Show resolved
Hide resolved
|
|
||
| _deleteBackup() { | ||
| const QuestionDialog = sdk.getComponent("dialogs.QuestionDialog"); | ||
| Modal.createTrackedDialog('Delete Backup', '', QuestionDialog, { |
There was a problem hiding this comment.
minor nit: doublequotes for strings, iirc? rather than flipping back and forth in the same method
There was a problem hiding this comment.
Our code style says single by default so I've changed them to be consistent that way (apart from the longer, more English-y ones that are liable to contain apostrophes).
|
that's pretty epic, and lgtm other than very minor nits. can't wait to use it! |
|
lgtm! |
Add passphrase support to backup creation stage
Passphrase Support for e2e backups
…covery_key Add recovery key download button
Taken over from #1703
element-hq/element-web#3661
Requires matrix-org/matrix-js-sdk#736