This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
postpone loading the members until the user joined the room #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when peeking, the members weren't being loaded at all because the room wasn't available yet, and the need for loading the members was never re-evaluated after that. This only loads the members once the user has joined the room, which also helps to avoid load all the members before an invite is accepted.
bwindels
changed the title
dbkr
reviewed
Sep 14, 2018
| @@ -163,14 +168,28 @@ module.exports = React.createClass({ | |||
| } | |||
| }, | |||
|
|
|||
| onRoom: function(room) { | |||
| onRoom: async function(room) { | |||
There was a problem hiding this comment.
Indeed, had to code shifted around more before landing at this.
| this._loadMembersIfNeeded(); | ||
| }, | ||
|
|
||
| onRoomMembership: async function(ev, member, oldMembership) { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when peeking, the members weren't being loaded at all because
the room wasn't available yet,
and the need for loading the members was never re-evaluated after that.
This only loads the members once the user has joined the room,
which also helps to avoid load all the members before an invite
is accepted.
Fixes element-hq/element-web#7321