This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix CPU spin on joining large room #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checkIfAlone() filters the whole member list, which is fine until we do it once for every membership event, then we have an n^2 problem. Move it into the rate limited function. Fixes element-hq/element-web#7163
bwindels
suggested changes
Aug 22, 2018
| @@ -717,6 +716,7 @@ module.exports = React.createClass({ | |||
| // refresh the conf call notification state | |||
| this._updateConfCallNotification(); | |||
| this._updateDMState(); | |||
| this._checkIfAlone(this.state.room); | |||
| }, 500), | |||
|
|
|||
| _checkIfAlone: function(room) { | |||
There was a problem hiding this comment.
Actually, this should now be implemented with roomstate getJoinedMemberCount + getInvitedMemberCount, which should be more performant and also more correct in case of lazy loading.
bwindels
approved these changes
Aug 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkIfAlone() filters the whole member list, which is fine until
we do it once for every membership event, then we have an n^2
problem. Move it into the rate limited function.
Fixes element-hq/element-web#7163