This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Don't show 'connection lost' bar on MAU error #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need both warning bars Requires matrix-org/matrix-js-sdk#680
|
Tests failing because I failed to give the branches matching names |
bwindels
reviewed
Aug 6, 2018
| this.state.syncStateData.error && | ||
| this.state.syncStateData.error.errcode === 'M_MAU_LIMIT_EXCEEDED' | ||
| ); | ||
| return this.state.syncState === "ERROR" && !errorIsMauError; |
There was a problem hiding this comment.
Won't this return true in case of a consent error? I presume on connection error there is no actual error object in the syncStateData? Maybe just check for that?
There was a problem hiding this comment.
The consent error is only for sending messages rather than syncing (we're only worried about the user putting data into the system rather than getting it out). The reason for specifying that it's a MAU error is to avoid the situation where we add another failure with a dedicated errcode and an older Riot that doesn't understand that errcode displays no error at all.
bwindels
approved these changes
Aug 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need both warning bars
Requires matrix-org/matrix-js-sdk#680
For element-hq/element-web#7091