Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Remove package-lock.json for now #2097

Merged
merged 4 commits into from
Aug 3, 2018
Merged

Remove package-lock.json for now #2097

merged 4 commits into from
Aug 3, 2018

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jul 31, 2018

As per element-hq/element-web#7083

The package-lock file is currently not bringing any of the benefits
it's supposed to bring because we don't do the neccessary things to
massage it during the release process. Remove it until we actually
manage it correctly.

As per element-hq/element-web#7083

The package-lock file is currently not bringing any of the benefits
it's supposed to bring because we don't do the neccessary things to
massage it during the release process. Remove it until we actually
manage it correctly.
@dbkr dbkr requested a review from a team July 31, 2018 10:06
@bwindels
Copy link
Contributor

Cool. Perhaps also include it in .gitignore?

@dbkr
Copy link
Member Author

dbkr commented Aug 1, 2018

Done

@bwindels
Copy link
Contributor

bwindels commented Aug 1, 2018

The GroupView tests are broken, hmm. Doesn't seem like it's due to test flakiness as I restarted the build with exactly the same result.

@dbkr
Copy link
Member Author

dbkr commented Aug 1, 2018

Eugh, presumably, having asserted npm isn't reading this file, presumably npm 6 on Travis is reading it and is preventing us from pulling in a new dependency which breaks the test. What a mess.

@bwindels
Copy link
Contributor

bwindels commented Aug 1, 2018

Interesting. Strange that adding it to .gitignore would trigger this. Seems to be a TypeError in the client (or the peg), in one of the fetchers in GroupView::_resourceFetcher. Would be good to see the stack. Ughh.

@bwindels
Copy link
Contributor

bwindels commented Aug 1, 2018

sanitize-html seems to be the offender. Adding it to .gitignore was probably not what caused the error but merging the PR in riot-web as it's in the manifest for both repos (with different versions)

...as hopefully this should work now sanitize-html is fixed?
@dbkr
Copy link
Member Author

dbkr commented Aug 2, 2018

indeed it did seem to be the sanitize-html thing

@dbkr dbkr merged commit 86c5fac into develop Aug 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants