This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Jitsi: Use integrations URL from config #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
reviewed
Jul 16, 2018
src/CallHandler.js
Outdated
| 'https://scalar.vector.im/api/widgets' + | ||
| '/jitsi.html?' + | ||
| SdkConfig.get().integrations_rest_url + | ||
| '/widgets/jitsi.html?' + |
There was a problem hiding this comment.
fwiw this breaks in Dimension given it expects an entirely different format. Is it possible to just have the entire URL configurable?
At least until https://github.com/matrix-org/matrix-doc/issues/1286 is a thing. It would also be nice if both Scalar and Dimension can agree on the parameters being used, as per the m.jitsi widget declaration in https://docs.google.com/document/d/1uPF7XWY_dXTKVKV7jZQ2KmsI19wn9-kFRgQ1tFQP7wQ/edit#
|
Yeah, this probably isn't ideal but at least it'll make it configurable for now. |
|
surely you need to add |
bwindels
approved these changes
Jul 20, 2018
|
otherwise lgtm |
|
Yep, element-hq/element-web#7055 adds to the sample config |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also element-hq/element-web#7055