Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Revert " make click to insert nick work on join/parts, /me's etc" #2034

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jul 3, 2018

@t3chguy t3chguy requested a review from a team July 3, 2018 09:30
@t3chguy
Copy link
Member Author

t3chguy commented Jul 3, 2018

This issue requires a refactor of the code to be able to generate both Textual and Richer (Element) representations of events.

@dbkr
Copy link
Member

dbkr commented Jul 3, 2018

Would be good to understand what's gone wrong here and how this has ended up changing the events that get generated.

@lukebarnard1
Copy link
Contributor

This also reverts a lot of translations that were done for the PR. Losing those would be a pain for translators as they'd have to re-translate. Can we keep them in?

@dbkr dbkr merged commit f429ae5 into develop Jul 3, 2018
@dbkr
Copy link
Member

dbkr commented Jul 3, 2018

oops, sorry luke. I Think all the translation changes were michael's script though.

@t3chguy
Copy link
Member Author

t3chguy commented Jul 3, 2018

@lukebarnard1 the only i18n changes I see are the ones I made using my script (replacing %(...)s with <...>)

@t3chguy
Copy link
Member Author

t3chguy commented Jul 3, 2018

Would be good to understand what's gone wrong here and how this has ended up changing the events that get generated.

things using TextForEvent rightly assume it returns strings, but by throwing JSX in there it ended up spitting back React Elements so now things started printing it as [Object object] instead

(Things like Notifier which is not capable of rendering React Elements)
the [Object object] in timeline is probably an issue internal to the original PR

@dbkr
Copy link
Member

dbkr commented Jul 3, 2018

ah right

@t3chguy
Copy link
Member Author

t3chguy commented Jul 3, 2018

this'll need more thought and a way of either getting a Textual Representation or a richer React Element one

@t3chguy t3chguy deleted the revert-1945-t3chguy/click_username_state_ev branch April 27, 2020 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants