This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Login local errors for blank fields #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
remove unused refs Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
dbkr
approved these changes
Jun 25, 2018
| @@ -56,33 +57,64 @@ class PasswordLogin extends React.Component { | |||
| this.onPhoneCountryChanged = this.onPhoneCountryChanged.bind(this); | |||
| this.onPhoneNumberChanged = this.onPhoneNumberChanged.bind(this); | |||
| this.onPasswordChanged = this.onPasswordChanged.bind(this); | |||
| this.isLoginEmpty = this.isLoginEmpty.bind(this); | |||
There was a problem hiding this comment.
ftr, I don't think you need to bind this as you're not passing it in as a callback anywhere. Arguably it's clearer if we just always bind component methods though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate local errors if blank {username,email,phone_number}{password} field
Fixes element-hq/element-web#5577