This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
improve command provider #1981
Merged
improve command provider #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve Regexp so it leaves autocomplete up whilst typing arguments improve completion so it doesn't discard your arguments on-hover add a way to list all commands by using `/<TAB>` Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
dbkr
reviewed
Jun 18, 2018
| @@ -2,6 +2,7 @@ | |||
| Copyright 2016 Aviral Dasgupta | |||
| Copyright 2017 Vector Creations Ltd | |||
| Copyright 2017 New Vector Ltd | |||
| Copyright 2018 Michael Telatynski <7t3chguy@gmail.com> | |||
There was a problem hiding this comment.
Not sure if this should be New Vector
There was a problem hiding this comment.
This wasn't a p1 issue and thus not chargeable hours so <Me/>
|
Otherwise lgtm |
dbkr
approved these changes
Jun 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#5069
Fixes second part of element-hq/element-web#5467