Share Dialog #1948
Share Dialog #1948
Conversation
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
|
Looks pretty nifty 👍. The social icons seem pretty arbitrary and feel like they'd be nicer as config options, or at least make them configurable. |
|
It'd be very easy to make this configurable, given its written in a data-driven manner, will poke toml about it his mockup was: |
| @@ -16,7 +16,7 @@ limitations under the License. | |||
|
|
|||
| .mx_ContextualMenu_wrapper { | |||
| position: fixed; | |||
| z-index: 2000; | |||
| z-index: 5000; | |||
There was a problem hiding this comment.
the Modal sits at Z 4000
so it needs to be higher
| @@ -1,5 +1,6 @@ | |||
| /* | |||
| Copyright 2015, 2016 OpenMarket Ltd | |||
| Copyright 2018 Vector Creations Ltd | |||
| @@ -1295,10 +1303,13 @@ module.exports = React.createClass({ | |||
|
|
|||
| <div className="mx_UserSettings_section"> | |||
| <div className="mx_UserSettings_advanced"> | |||
| { _t("Logged in as:") } { this._me } | |||
| { _t("Logged in as:") + ' ' } | |||
| <span onClick={this.onSelfShareClick} className="mx_UserSettings_link"> | |||
There was a problem hiding this comment.
Please don't put onClicks on spans: it's styled to look like a link on the screen, but to people using a screen reader this is just text. A thing that causes a dialog to pop up when you click on it is a button, or failing that, a hyperlink.
| @@ -0,0 +1,211 @@ | |||
| /* | |||
| Copyright 2018 Vector Creations Ltd | |||
| img: 'img/social/', | ||
| url: (url) => `https://plus.google.com/share?url=${url}`, | ||
| },*/ { | ||
| name: 'Linked In', |
| this.onCheckboxClick = this.onCheckboxClick.bind(this); | ||
|
|
||
| this.state = { | ||
| ticked: false, |
| e.target.onmouseleave = close; | ||
| } | ||
|
|
||
| onCheckboxClick() { |
There was a problem hiding this comment.
As per 'ticked', some name suggestive of what the checkbox is for would be nice.
|
|
||
| <div className="mx_ShareDialog_split"> | ||
| <div className="mx_ShareDialog_left"> | ||
| <h3>QR Code</h3> |
There was a problem hiding this comment.
I'd argue that if you know how to use a QR code, you probably don't need to be told that this is one.
There was a problem hiding this comment.
So you want to see the "QR Code" and "Social" headers disappear? or just one and have it lobsided
There was a problem hiding this comment.
Yeah, I would say remove both - that lgtm. @lampholder ?
| <h3>Social</h3> | ||
| <div className="mx_ShareDialog_social_container"> | ||
| { | ||
| socials.map((social) => <a target="_blank" |
| href={social.url(encodedUrl)} | ||
| className="mx_ShareDialog_social_icon" | ||
| > | ||
| <img src={social.img} height={64} width={64} /> |
fix copyright headers fix user settings link accessibility fix typo and add noopener Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
|
@dbkr PTAL |
Implements a share dialog for users rooms and groups
fixes ContextMenu such that it can overlay modals if needed
fixes BaseDialog and a typo in a Dialog
specs some more PropTypes which were previously used but not specified
Requires matrix-org/matrix-js-sdk#656Fixes element-hq/element-web#877
Fixes element-hq/element-web#2943