This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Make devTools styling more consistent and easier to edit event data. #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
reviewed
May 23, 2018
| .mx_DevTools_RoomStateExplorer_button, .mx_DevTools_RoomStateExplorer_query { | ||
| margin-bottom: 10px; | ||
| max-width: 684px; |
There was a problem hiding this comment.
The dialog is hard-coded to a width of 704px (I've no idea why), subtract the margins and padding on the dialog (that can't be changed from this component, or without messing with a lot of other stuff) and you get/got 684px.
However, this was when I was attempting to wrap all of the devTools content in "mx_DevTools_content" containers for consistency, and it turns out that this is a lot bigger job than I was hoping for. Without making those changes this doesn't actually make a lot of sense, so I'll back it out. Thanks for catching that.
|
I'm happy to see devtools has become so useful and thank you very much for making it look better :D |
t3chguy
approved these changes
May 23, 2018
dbkr
approved these changes
May 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is inconsistent styling when viewing as opposed to editing room and account data (see screenshots). Before:
This PR adds styling for consistency between views and to make it easier to edit events (in the displayed modal).
After: