This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add a "reload widget" button. #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rxl881 what's wrong with right-click -> "Reload frame" ? |
|
@lukebarnard1 - It's a fair point, it's most likely to be useful in the case (not for stickers, but for most other widgets) where we have to two nested layers of iframe. This button will reload all of the widget, reload frame is likely just to be the inner content, which is probably not what you want. |
dbkr
approved these changes
May 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a "reload widget" button to allow the user to force reloading of a widget content URL.
This is not (currently) intended for use with production widgets, but is useful in development of "persistent" widgets such as stickerpickers to force reloading of widget content without reloading the whole of riot.
This is currently disabled by default, but can be easily enabled in development by passing "showReload" to the widget AppTile.