This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 832
Fix UX issues with bug report dialog #1863
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6d9e075
UI fixes in SessionRestoreErrorDialog
dbkr 2987e2c
Merge remote-tracking branch 'origin/dbkr/fix_session_restore_error_h…
dbkr dc06c52
Merge remote-tracking branch 'origin/dbkr/fix_session_restore_error_h…
dbkr efd2919
Fix UX issues with bug report dialog
dbkr 27b18c4
Lint
dbkr 74651b9
Merge remote-tracking branch 'origin/dbkr/fix_session_restore_fail_di…
dbkr fc13660
UI fixes in SessionRestoreErrorDialog
dbkr 37cb8ab
Fix UX issues with bug report dialog
dbkr a9b6db3
Lint
dbkr dcaacfd
Merge remote-tracking branch 'origin/develop' into dbkr/fix_session_r…
dbkr 5d46efc
Get docs right on hasCancel
dbkr 54cccab
Factor out clearStorageButton
dbkr c3420c3
Indentation
dbkr e28a927
lint
dbkr d743e6a
Merge branch 'dbkr/bug_report_dialog_basedialog' of github.com:matrix…
dbkr 025bffb
Merge remote-tracking branch 'origin/dbkr/fix_session_restore_fail_di…
dbkr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a code perspective, fine. From a UI perspective though, this text should very much be white.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the text on all the red buttons is black in the dark theme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. Sorry, I should've looked at what the colours actually are.