This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Use mxid as sender name on set display name #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it was, "<New name> set their display name to <New name>" which is unhelpful because you never knew them as "<New name>" before. They would previously have been displayed with their matrix ID, so that's what should be here.
|
@dbkr: we shouldn't be leaking user IDs. Not sure how to do this otherwise though, other than "Bob added a display name". |
|
We show the user ID by user ID every time they sent a message prior to this display name change, so I don't think that argument makes sense. |
|
This is true. Fair enough! |
lukebarnard1
approved these changes
Apr 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was,
"<New name> set their display name to <New name>"whichis unhelpful because you never knew them as
"<New name>"before.They would previously have been displayed with their matrix ID, so
that's what should be here.