Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add radio button for setting group is_joinable #1817

Merged
merged 5 commits into from
Apr 5, 2018

Conversation

lukebarnard1
Copy link
Contributor

which dictates whether the group can be joined without invitation.

which dictates whether the group can be joined without invitation.
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, modulo possibly swapping out the values for different onClick handlers or something as IRLed

@dbkr dbkr assigned lukebarnard1 and unassigned dbkr Mar 29, 2018
@lukebarnard1 lukebarnard1 assigned dbkr and unassigned lukebarnard1 Apr 5, 2018
@dbkr
Copy link
Member

dbkr commented Apr 5, 2018

Updated to use new join_policy API, so requires matrix-org/matrix-js-sdk#636 but caveat: the API for reading this flag is pretty nonsensical right now.

Copy link
Contributor Author

@lukebarnard1 lukebarnard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (can't approve my own PR)

@lukebarnard1 lukebarnard1 merged commit 59abfa6 into develop Apr 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants