Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

[DO NOT MERGE] Tests proven to fail #1780

Merged
merged 4 commits into from
Feb 28, 2018
Merged

Commits on Feb 28, 2018

  1. Add tests for RoomSettings

    For setting:
     - name
     - topic
     - history visibility
     - power levels
    
    Testing RoomSettings required more stubbing on the matrix client.
    
    The power level tests should be failing at this commit, with
    fixes being made in upcoming commits.
    
    Some tests are marked as known failures that we should fix but
    aren't necessarily bugs:
     - SettingStore.setValue is used when saving despite the user not
       having made a change.
     - Testing directory publicity changes cannot be tested because we
       update state asynchronously in componentWillMount (which we do
       not block on in beforeEach).
    
    Also, we needed to use `export default` to make sure everything
    uses the same client peg and client.
    lukebarnard1 committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    d91d193 View commit details
    Browse the repository at this point in the history
  2. Remove unused prop

    lukebarnard1 committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    dd52979 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9a72e69 View commit details
    Browse the repository at this point in the history
  4. Update PowerSelector to support powerLevelKey prop

    As a key to send as second argument to onChange. This is useful
    when passing the same callback to multiple PowerSelectors.
    lukebarnard1 committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    567d83b View commit details
    Browse the repository at this point in the history