This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Swap RoomList to react-beautiful-dnd #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebarnard1
added a commit
to element-hq/element-web
that referenced
this pull request
Jan 18, 2018
Includes themeing\n\nSee matrix-org/matrix-react-sdk#1711
lukebarnard1
added a commit
to element-hq/element-web
that referenced
this pull request
Jan 18, 2018
Includes themeing See matrix-org/matrix-react-sdk#1711
lukebarnard1
force-pushed
the
luke/roomlist-beautiful-dnd
branch
from
a4781f6
to
dfecad1
Compare
ara4n
reviewed
Jan 18, 2018
| @@ -649,6 +747,7 @@ module.exports = React.createClass({ | |||
|
|
|||
| const self = this; | |||
| return ( | |||
| <DragDropContext onDragEnd={this.onRoomTileEndDrag}> | |||
There was a problem hiding this comment.
Might be nice to fix the indentation here.
|
looks plausible to me (modulo test fails) - is this going to break fa14bc9 though? |
I am not sure what that is or how it's related. |
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.