This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Replace TagPanel react-dnd with react-beautiful-dnd #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new library handles the simple case of an ordered vertical (or horizontal) list of items that can be reordered. It provides animations, handles positioning of items mid-drag and exposes a much simpler API to react-dnd (with a slight loss of potential function, but we don't need this flexibility here anyway). Apart from this, TagOrderStore had to be changed in a highly coupled way, but arguably for the better. Instead of being updated incrementally every time an item is dragged over another and having a separate "commit" action, the asyncronous action `moveTag` is used to reposition the tag in the list and both dispatch an optimistic update and carry out the request as before. (The MatrixActions.accountData is still used to indicate a successful reordering of tags). The view is updated instantly, in an animated way, and this is handled at the layer "above" React by the DND library.
|
And for once Travis CI is being annoying and isn't starting chrome |
|
This fixes element-hq/element-web#5910 and element-hq/element-web#5912 This also probably fixes element-hq/element-web#5839 |
dbkr
reviewed
Jan 16, 2018
.travis.yml
Outdated
| @@ -3,7 +3,9 @@ dist: trusty | |||
|
|
|||
| # we don't need sudo, so can run in a container, which makes startup much | |||
| # quicker. | |||
| sudo: false | |||
| # | |||
| # unfortunately we do require sudo as per https://github.com/travis-ci/travis-ci/issues/8836 | |||
There was a problem hiding this comment.
At some point they should fix the issue, sure.
|
otherwise lgtm |
|
Having tested this locally again, it seems clicking TagPanel doesn't deselect all tags. Will fix here. |
For some reason, after dragging an item the parent draggable receives a mouse click. The workaround is to use onMouseDown for deselecting tags
dbkr
reviewed
Jan 16, 2018
yep, sure, sorry totally blanked on that one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new library handles the simple case of an ordered vertical
(or horizontal) list of items that can be reordered.
It provides animations, handles positioning of items mid-drag
and exposes a much simpler API to react-dnd (with a slight loss
of potential function, but we don't need this flexibility here
anyway).
Apart from this, TagOrderStore had to be changed in a highly
coupled way, but arguably for the better. Instead of being
updated incrementally every time an item is dragged over
another and having a separate "commit" action, the
asyncronous action
moveTagis used to reposition the tag inthe list and both dispatch an optimistic update and carry out
the request as before. (The MatrixActions.accountData is still
used to indicate a successful reordering of tags).
The view is updated instantly, in an animated way, and this
is handled at the layer "above" React by the DND library.