This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Allow guests to view individual groups #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For homeservers that still disallow guests (running synapse without matrix-org/synapse#2715), start ILAG.
To avoid weirdness with using a cached matrix client
|
Test has flaked here. |
dbkr
approved these changes
Nov 28, 2017
Why? I separated the commits. I realised that using a cached matrixClient affected the viewing of groups as a guest that does onboarding. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the server disallows guests from accessing them (if hasn't got matrix-org/synapse#2715), start ILAG with an intention to return to the group.
Fixes element-hq/element-web#5650
Also, use MatrixClientPeg in the GroupStore to prevent weirdness when logging out/in - we don't want to cache old sessions. In my mind, this is a reason to either: