Fix linting errors. #1610
Fix linting errors. #1610
Conversation
|
I HATE our linter. thanks. |
| @@ -376,8 +383,7 @@ class Tinter { | |||
| const attr = this.svgAttrs[k]; | |||
| for (let l = 0; l < this.keyHex.length; l++) { | |||
| if (tag.getAttribute(attr) && | |||
| tag.getAttribute(attr).toUpperCase() === this.keyHex[l]) | |||
| { | |||
| tag.getAttribute(attr).toUpperCase() === this.keyHex[l]) { | |||
There was a problem hiding this comment.
the style we would generally go with is
if (reallyLongstuff &&
otherReallyLongStuff
) {
bla
There was a problem hiding this comment.
says who, though? i've never used that style in my life, and it's not in our code style (https://github.com/matrix-org/matrix-react-sdk/blob/master/code_style.md), and I don't understand why we are enforcing lint rules which are more extreme than our code style!
There was a problem hiding this comment.
I've never seen that, actually. We really ought to update the linting configuration to reflect that.
There was a problem hiding this comment.
Yes. just to be clear: linting is meant to fix bugs and help legibility in terms of enforcing a consistent style - but there is no benefit in making it needlessly over-restrictive (especially based on personal taste, when there's already a formal style). I don't think anyone's eyes are ever going jar at where the { goes after an multiline if clause, so in the end it just burns time having to fix up unnecessary linting errors. In other words: we should introduce linting where it helps us, not slows us down, and certainly not for the sake of arbitrary consistency.
As Emerson said (and I think the old MX Coding Style guide as written by vdh & myself about 15 years ago, which you have more of an excuse not to have read ;): A foolish consistency is the hobgoblin of little minds.
There was a problem hiding this comment.
+1 to having the lint less strict. It's getting tiring to have an "appease the linter" commit on every PR.
There was a problem hiding this comment.
I don't find it that bad, but then I do have the linting built into my IDE, so there's no extra "appeasing" step in general.
No description provided.