-
-
Notifications
You must be signed in to change notification settings - Fork 832
Add some missing translatable strings #1588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Addresses" is not an i18n'd string in at least en_EN.json
Oh yeah, so it should also be added to english? I'm sorry I assumed this will be generated automagically. |
I think there's a script to run, which will generate it automatically, but its a development task |
Hmm, looks like this conflicts with my earlier changes to PowerSelector. @pvagner if you feel like fixing the conflicts, that'd be great, although I suspect I may have fixed element-hq/element-web#5547 inadvertently, so it might be worth checking if that's still an issue on |
I also broke it by removing You can use |
@lukebarnard1 My change related to the PowerSelector is no longer needed as you have already addressed that. |
…translatable. Fixes matrix-org#5547" This reverts commit 681f439.
@pvagner let me know when you need me to take another look at this. |
@lukebarnard1: Well, I think this is done. I consider this as a minor thing. The only thing I don't know how to handle is to satisfy @t3chguy's review request. |
Okay, I shall merge because LGTM. Thanks! |
Came accross a few missing translatable strings.