Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add some missing translatable strings #1588

Merged
merged 6 commits into from
Dec 7, 2017

Conversation

pvagner
Copy link
Contributor

@pvagner pvagner commented Nov 8, 2017

Came accross a few missing translatable strings.

t3chguy
t3chguy approved these changes Nov 8, 2017
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Addresses" is not an i18n'd string in at least en_EN.json

@pvagner
Copy link
Contributor Author

pvagner commented Nov 8, 2017

Oh yeah, so it should also be added to english? I'm sorry I assumed this will be generated automagically.

@t3chguy
Copy link
Member

t3chguy commented Nov 8, 2017

I think there's a script to run, which will generate it automatically, but its a development task

@t3chguy
Copy link
Member

t3chguy commented Nov 8, 2017

@pvagner pvagner changed the title Make the addresses heading on the aliases settings view translatable Add some missing translatable strings Nov 10, 2017
@lukebarnard1
Copy link
Contributor

Hmm, looks like this conflicts with my earlier changes to PowerSelector.

@pvagner if you feel like fixing the conflicts, that'd be great, although I suspect I may have fixed element-hq/element-web#5547 inadvertently, so it might be worth checking if that's still an issue on /develop.

@pafcu
Copy link
Contributor

pafcu commented Nov 16, 2017

I also broke it by removing _tJsx() :-(

You can use _t() instead now. Let me know if you need help with making the changes.

@pvagner
Copy link
Contributor Author

pvagner commented Nov 16, 2017

@lukebarnard1 My change related to the PowerSelector is no longer needed as you have already addressed that.
I have to revert it and add some more unlabeled stuff e.g. not translatable alt texts on the homepage.

@lukebarnard1
Copy link
Contributor

@pvagner let me know when you need me to take another look at this.

@pvagner
Copy link
Contributor Author

pvagner commented Dec 6, 2017

@lukebarnard1: Well, I think this is done. I consider this as a minor thing. The only thing I don't know how to handle is to satisfy @t3chguy's review request.
Everything is committed and merge conflicts are solved.
If I were you I would just accept the PR. But still if you find something you think I might have overlooked, then I'm happy to correct it right away.

@lukebarnard1
Copy link
Contributor

Okay, I shall merge because LGTM. Thanks!

@lukebarnard1 lukebarnard1 merged commit 4603d59 into matrix-org:develop Dec 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants