Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add checkbox to GroupAddressPicker for determining visibility of group rooms #1587

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Add checkbox to GroupAddressPicker for determining visibility of group rooms #1587

merged 1 commit into from
Nov 8, 2017

Conversation

lukebarnard1
Copy link
Contributor

@lukebarnard1 lukebarnard1 commented Nov 7, 2017 •
edited
Loading

@ara4n
Copy link
Member

ara4n commented Nov 7, 2017

lgtm. i wonder a bit if we should default the room's visibility based on its visibility in publicRooms API - after all, if a room's in publicRooms you probably want to see it in a group, and if it's not you probably don't. But this is fine for now.

@ara4n ara4n assigned lukebarnard1 and unassigned ara4n Nov 7, 2017
@lukebarnard1
Copy link
Contributor Author

if a room's in publicRooms you probably want to see it in a group, and if it's not you probably don't

I can't think really think of a counter-example. It seems slightly odd that a room admin would impose the default setting for something that they ultimately might never interact with or care about.

@lukebarnard1 lukebarnard1 merged commit 4c47f75 into develop Nov 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@lukebarnard1 lukebarnard1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When adding a room to a group, have checkbox to select its privacy
2 participants
@lukebarnard1 @ara4n