Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Only show admin tools to privileged users #1555

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Only show admin tools to privileged users #1555

merged 1 commit into from
Oct 30, 2017

Conversation

lukebarnard1
Copy link
Contributor

dbkr
dbkr reviewed Oct 30, 2017
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it still show a spinner whilst it fetches the relevant stuff from the server?

otherwise lgtm

@dbkr dbkr assigned lukebarnard1 and unassigned dbkr Oct 30, 2017
@lukebarnard1
Copy link
Contributor Author

The conclusion was no it doesn't, but we don't do that elsewhere either. In an ideal world the GroupStore would have ready state for each API that it could set to false when the first fetching is ongoing (i.e. when loading the room list for the first time).

User privileges will only appear to have been changed when the summary is fetched, which will most likely occur when mounting the group page (possibly for the first time).

@lukebarnard1 lukebarnard1 merged commit 19b798b into develop Oct 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbkr dbkr dbkr left review comments

Assignees

@lukebarnard1 lukebarnard1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebarnard1 @dbkr