Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add eslint rule to disallow spaces inside of curly braces #1436

Merged
merged 8 commits into from
Sep 28, 2017

Conversation

lukebarnard1
Copy link
Contributor

No description provided.

@t3chguy
Copy link
Member

t3chguy commented Sep 28, 2017

does this hit both props and elements?
I.e

<Foo thing={true}>
    { thing }
</Foo>

or does it prevent spaces for { thing } too?

Luke Barnard added 2 commits September 28, 2017 11:21
This required an updated in version of eslint-plugin-react to 7.4.0.
…atrix-react-sdk into luke/lint-jsx-curly-spacing
@lukebarnard1
Copy link
Contributor Author

lukebarnard1 commented Sep 28, 2017

@t3chguy it now lints for to make sure the style of your snippet is enforced

@t3chguy
Copy link
Member

t3chguy commented Sep 28, 2017

AWESOME!!

@dbkr
Copy link
Member

dbkr commented Sep 28, 2017

The spaces look a bit weird to me in things like:

{ _t(...
) }

...but it is nice that it's consistent.

@lukebarnard1 lukebarnard1 merged commit 6a988a0 into develop Sep 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants