This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix ability to feature self in a group summary #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the AddressPicker would omit the currently logged-in user. This adds a property to override that to allow "self" to be picked.
dbkr
reviewed
Sep 27, 2017
There was a problem hiding this comment.
Standard complaint about options always being positive, ie. I think includeSelf defaulting to false would be clearer, otherwise you end up going, "no, don't omit myself" which is a bit of a double negative. Not that this is too bad, so not that bothered.
lgtm
|
Agreed, clarity FTW |
dbkr
approved these changes
Sep 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the AddressPicker would omit the currently logged-in user. This adds a property to override that to allow "self" to be picked.