This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Create GroupSummaryStore for storing group summary stuff #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lukebarnard1
commented
Sep 22, 2017
lukebarnard1
commented
- Acts as a layer between GroupView and the group APIs that modify the summary individually. This allows for abstraction of getting the new summary once a successful API hit has been done.
- The plan is to also control the avatar, topic, body of the summary via the same class
- Acts as a layer between GroupView and the group APIs that modify the summary individually. This allows for abstraction of getting the new summary once a successful API hit has been done. - The plan is to also control the avatar, topic, body of the summary via the same class
|
Arguably this shouldn't use the client peg.. |
dbkr
reviewed
Sep 25, 2017
| @@ -411,12 +430,16 @@ export default React.createClass({ | |||
| }, | |||
|
|
|||
| _loadGroupFromServer: function(groupId) { | |||
| MatrixClientPeg.get().getGroupSummary(groupId).done((res) => { | |||
| this._groupSummaryStore = new GroupSummaryStore( | |||
There was a problem hiding this comment.
Hmm, I'm assuming there's no references retained to the GroupSummaryStore so it will all GC nicely, but might be nice to explicitly remove the listener on the old one anyway.
| @@ -411,12 +430,16 @@ export default React.createClass({ | |||
| }, | |||
|
|
|||
| _loadGroupFromServer: function(groupId) { | |||
There was a problem hiding this comment.
This feels like a bit of misnomer now since what's is mostly doing is initialising the store
dbkr
approved these changes
Sep 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.