This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Implement removal function of features users/rooms #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the appeareance of a "X" in the top right of each featured item when editing. NB: No reloading of summary is done after adding/removing a user/room. The plan is to better than threading a callback all the way down.
dbkr
reviewed
Sep 22, 2017
src/i18n/strings/en_EN.json
Outdated
| "You are an administrator of this group": "You are an administrator of this group", | ||
| "Failed to remove the room from the summary of %(groupId)s": "Failed to remove the room from the summary of %(groupId)s", | ||
| "The room '%(roomName)' could not be removed from the summary.": "The room '%(roomName)' could not be removed from the summary." | ||
| "Failed to remove a user from the summary of %(groupId)s": "Failed to remove a user from the summary of %(groupId)s", |
|
(The tests flaked) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the appeareance of a "X" in the top right of each featured item when editing.
NB: No reloading of summary is done after adding/removing a user/room. The plan is to better than threading a callback all the way down.
CSS: element-hq/element-web#5103