This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Show who redacted an event on hover #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix matrix-org#3931 although it's not obvious who actually performed the redaction. Signed-off-by: Travis Ralston <travpc@gmail.com>
|
lgtm - thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix element-hq/element-web#3931 although it's not obvious who actually performed the redaction.
Note: Putting the "Message redacted by whoever" in the body just doesn't look very good. This is why the I went with the tooltip.
This PR does not consider collapsing redactions: this feels like a different concern.
Suggestions welcome on alternatives for displaying this information.