This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
allow hiding of notification body for privacy reasons #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
dbkr
reviewed
Sep 6, 2017
| if (!global.localStorage) return true; | ||
| const enabled = global.localStorage.getItem('notifications_body_enabled'); | ||
| // default to true if the popups are enabled | ||
| if (enabled === null) return this.isEnabled(); |
There was a problem hiding this comment.
Why this.isEnabled() here but true at the top? I'd probably just return the raw setting.
src/Notifier.js
Outdated
| ) : null; | ||
| if (!this.isBodyEnabled()) { | ||
| msg = ''; | ||
| } |
There was a problem hiding this comment.
Surely blindly setting the message to the empty string is not what we want here? I'd have thought it should at least read 'message' (or 'image' etc)? Possibly even move some information from the title into the body, so it instead of, "Bob in The Room", "Message", it would be, "The Room", "Bob sent a message" or something.
Also, although I don't think you can turn notifications on for them in Riot, this would also break notifications for other events like joins/parts/room name changes etc.
|
i agree with dave's feedback, but it's better than nothing in the current form. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com
for element-hq/element-web#3814