This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Force update on timelinepanel when event decrypted #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially fixes element-hq/element-web#4865 (the part about messages not appearing in the timeline until you move the cursor over the window). Requires matrix-org/matrix-js-sdk#529
richvdh
suggested changes
Aug 24, 2017
| // TODO: We should restrict this to only events in our timeline, | ||
| // but possibly the event tile itself should just update when this | ||
| // happens to save us re-rendering the whole timeline. | ||
| this.forceUpdate(); |
There was a problem hiding this comment.
hrm; surely we should at least check the room id of the event?
|
I wonder if it's worth debouncing the forced update? |
|
@lukebarnard1 possibly, but we don't do it onRoomTimeline so if that hasn't been causing issues, I'm going to say it's probably better to leave it out for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes element-hq/element-web#4865
(the part about messages not appearing in the timeline until you
move the cursor over the window).
Requires matrix-org/matrix-js-sdk#529