Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Avoid error when DMing oneself #11754

Merged
merged 3 commits into from
Oct 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/createRoom.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,10 @@ export default async function createRoom(client: MatrixClient, opts: IOpts): Pro
const createOpts: ICreateRoomOpts = opts.createOpts || {};
createOpts.preset = createOpts.preset || defaultPreset;
createOpts.visibility = createOpts.visibility || Visibility.Private;
if (opts.dmUserId && createOpts.invite === undefined) {

// We allow UX of DMing ourselves as a form of creating a personal room but the server throws
// an error when a user tries to invite themselves so we filter it out
if (opts.dmUserId && opts.dmUserId !== client.getUserId() && createOpts.invite === undefined) {
switch (getAddressType(opts.dmUserId)) {
case "mx-user-id":
createOpts.invite = [opts.dmUserId];
Expand Down
9 changes: 9 additions & 0 deletions test/createRoom-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,15 @@ describe("createRoom", () => {
}),
);
});

it("should strip self-invite", async () => {
await createRoom(client, { dmUserId: client.getSafeUserId() });
expect(client.createRoom).toHaveBeenCalledWith(
expect.not.objectContaining({
invite: expect.any(Array),
}),
);
});
});

describe("canEncryptToAllUsers", () => {
Expand Down
Loading