Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Implement permalink end-2-end test #10434

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Mar 23, 2023

Blocked by #10425

Part of element-hq/element-meta#1030

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added T-Task Refactoring, enabling or disabling functionality, other engineering tasks X-Needs-Percy Whether to run Percy screenshot tests in Merge Queue labels Mar 23, 2023
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise though

cypress/e2e/permalinks/permalinks.spec.ts Show resolved Hide resolved
cypress/e2e/permalinks/permalinks.spec.ts Show resolved Hide resolved
@weeman1337 weeman1337 merged commit 968b6fc into develop Mar 29, 2023
@weeman1337 weeman1337 deleted the weeman1337/permalink-e2e-test branch March 29, 2023 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks X-Needs-Percy Whether to run Percy screenshot tests in Merge Queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants