This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Refactor custom logic to use the shared canResetTimeline() function
#10403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
added
the
T-Task
MadLittleMods
commented
Mar 17, 2023
| @@ -773,7 +773,7 @@ class TimelinePanel extends React.Component<IProps, IState> { | |||
| private onRoomTimelineReset = (room: Room, timelineSet: EventTimelineSet): void => { | |||
| if (timelineSet !== this.props.timelineSet) return; | |||
|
|
|||
| if (this.messagePanel.current && this.messagePanel.current.isAtBottom()) { | |||
| if (this.canResetTimeline()) { | |||
There was a problem hiding this comment.
The logic is equivalent to before:
3 tasks
weeman1337
approved these changes
Mar 20, 2023
MadLittleMods
deleted the
madlittlemods/fix-missed-refactor-canResetTimeline
branch
|
Thanks for the review @weeman1337 🐢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor custom logic to use the shared
canResetTimeline()functionSplit out from #8354 (comment)
Dev notes
matrix-react-sdk/src/components/structures/TimelinePanel.tsx
Line 781 in bc60e59
matrix-react-sdk/src/components/structures/RoomView.tsx
Lines 1277 to 1282 in bc60e59
Checklist
Sign-off given on the changes (see CONTRIBUTING.md)This change is marked as an internal change (Task), so will not be included in the changelog.