This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Implement /user/@userid:domain?action=chat #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a URL that can be used to start a chat with a user. - If the user is a guest, setMxId dialog will appear before anything and a defered action will cause `ChatCreateOrReuseDialog` to appear once they've logged in. - If the user is registered, they will not see the setMxId dialog. fixes element-hq/element-web#4034
dbkr
approved these changes
Jun 2, 2017
src/createRoom.js
Outdated
| @@ -97,6 +97,7 @@ function createRoom(opts) { | |||
| // the room exists, causing things like | |||
| // https://github.com/vector-im/vector-web/issues/1813 | |||
| if (opts.andView) { | |||
| console.info('And viewing'); | |||
There was a problem hiding this comment.
did you mean to leave this in - it's a bit cryptic
There was a problem hiding this comment.
nope, I'll remove it!
lukebarnard1
pushed a commit
to element-hq/element-web
that referenced
this pull request
Jun 2, 2017
Possble thanks to matrix-org/matrix-react-sdk#1006
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a URL that can be used to start a chat with a user.
ChatCreateOrReuseDialogto appear once they've logged in.fixes element-hq/element-web#4034