Fix nulls leaking into geo urls (#7433)

matrix-org · Dec 21, 2021 · b412067 · b412067
1 parent d4bafdc
commit b412067
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/src/components/views/location/LocationPicker.tsx b/src/components/views/location/LocationPicker.tsx
@@ -289,12 +289,12 @@ export function getGeoUri(position: GeolocationPosition): string {
     const lat = position.coords.latitude;
     const lon = position.coords.longitude;
     const alt = (
-        position.coords.altitude !== undefined
+        Number.isFinite(position.coords.altitude)
             ? `,${position.coords.altitude}`
             : ""
     );
     const acc = (
-        position.coords.accuracy !== undefined
+        Number.isFinite(position.coords.accuracy)
             ? `;u=${ position.coords.accuracy }`
             : ""
     );

diff --git a/test/components/views/location/LocationPicker-test.tsx b/test/components/views/location/LocationPicker-test.tsx
@@ -35,6 +35,22 @@ describe("LocationPicker", () => {
             expect(getGeoUri(pos)).toEqual("geo:43.2,12.4");
         });
 
+        it("Nulls in location are not shown in URI", () => {
+            const pos: GeolocationPosition = {
+                coords: {
+                    latitude: 43.2,
+                    longitude: 12.4,
+                    altitude: null,
+                    accuracy: null,
+                    altitudeAccuracy: null,
+                    heading: null,
+                    speed: null,
+                },
+                timestamp: 12334,
+            };
+            expect(getGeoUri(pos)).toEqual("geo:43.2,12.4");
+        });
+
         it("Renders a URI with 3 coords", () => {
             const pos: GeolocationPosition = {
                 coords: {