Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add join_rule field to /publicRooms response #3673

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Add join_rule field to /publicRooms response #3673

merged 1 commit into from
Aug 23, 2023

Conversation

charlynguyen
Copy link
Contributor

@charlynguyen charlynguyen commented Aug 23, 2023 •
edited by github-actions bot
Loading

We @nordeck are currently implementing the knock rooms behind the feature flag feature_ask_to_join (introduced in matrix-org/matrix-react-sdk#11182).

This pull request adds the join_rule field to /publicRooms response (MSC2403).

Epic: element-hq/element-web#18655

Blocks

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

Add join_rule field to /publicRooms response
6dd5ab6 
Signed-off-by: Charly Nguyen <charly.nguyen@nordeck.net>
@github-actions github-actions bot added T-Enhancement Z-Community-PR Issue is solved by a community member's PR labels Aug 23, 2023
@charlynguyen charlynguyen mentioned this pull request Aug 23, 2023
Closed
3 tasks
@charlynguyen charlynguyen marked this pull request as ready for review August 23, 2023 12:46
@charlynguyen charlynguyen requested a review from a team as a code owner August 23, 2023 12:46
germain-gg
germain-gg approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good, thank you for your contribution!

@germain-gg germain-gg added this pull request to the merge queue Aug 23, 2023
Merged via the queue into matrix-org:develop with commit 321679f Aug 23, 2023
26 checks passed
@charlynguyen charlynguyen deleted the charlynguyen/add-join-rule-field-to-public-rooms-response branch August 23, 2023 13:58
@charlynguyen charlynguyen mentioned this pull request Aug 29, 2023
Merged
3 tasks
This was referenced Aug 29, 2023
Closed
Merged
This was referenced Aug 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlynguyen @germain-gg