Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MSC3952: intentional mentions #3092

Merged
merged 10 commits into from
Mar 22, 2023

Conversation

clokep
Copy link
Member

@clokep clokep commented Jan 24, 2023

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

See matrix-org/matrix-react-sdk#9983 & matrix-org/matrix-spec-proposals#3952.

Fixes element-hq/element-web#24376


Here's what your changelog entry will look like:

✨ Features

Copy link
Contributor

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few very minor comments and questions.

spec/unit/pushprocessor.spec.ts Outdated Show resolved Hide resolved
src/pushprocessor.ts Show resolved Hide resolved
src/pushprocessor.ts Outdated Show resolved Hide resolved
src/pushprocessor.ts Outdated Show resolved Hide resolved
src/pushprocessor.ts Outdated Show resolved Hide resolved
@clokep clokep removed the request for review from dbkr March 21, 2023 13:53
@clokep
Copy link
Member Author

clokep commented Mar 22, 2023

Thanks! 👍 Will wait to merge this until matrix-org/matrix-react-sdk#9983 is approved just to ensure there's nothing else that needs to happen.

@clokep clokep added this pull request to the merge queue Mar 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 22, 2023
clokep added a commit to matrix-org/matrix-react-sdk that referenced this pull request Mar 22, 2023
Add a method to the fake MatrixClient used in tests for compatibility with
changes in matrix-org/matrix-js-sdk#3092. This stops the downstream tests
from failing on that PR.
@clokep clokep added this pull request to the merge queue Mar 22, 2023
@clokep clokep merged commit fc55c4c into matrix-org:develop Mar 22, 2023
@clokep clokep deleted the intentional-mentions branch March 22, 2023 20:41
toomore pushed a commit to moda-gov-tw/matrix-org.matrix-react-sdk that referenced this pull request Apr 6, 2023
Add a method to the fake MatrixClient used in tests for compatibility with
changes in matrix-org/matrix-js-sdk#3092. This stops the downstream tests
from failing on that PR.
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Apr 21, 2023
* Allow via_servers property in findPredecessor (update to MSC3946) ([\matrix-org#3240](matrix-org#3240)). Contributed by @andybalaam.
* Fire `closed` event when IndexedDB closes unexpectedly ([\matrix-org#3218](matrix-org#3218)).
* Implement MSC3952: intentional mentions ([\matrix-org#3092](matrix-org#3092)). Fixes element-hq/element-web#24376.
* Send one time key count and unused fallback keys for rust-crypto ([\matrix-org#3215](matrix-org#3215)). Fixes element-hq/element-web#24795. Contributed by @florianduros.
* Improve `processBeaconEvents` hotpath ([\matrix-org#3200](matrix-org#3200)).
* Implement MSC3966: a push rule condition to check if an array contains a value ([\matrix-org#3180](matrix-org#3180)).
* indexddb-local-backend - return the current sync to database promise … ([\matrix-org#3222](matrix-org#3222)). Contributed by @texuf.
* Revert "Add the call object to Call events" ([\matrix-org#3236](matrix-org#3236)).
* Handle group call redaction ([\matrix-org#3231](matrix-org#3231)). Fixes vector-im/voip-internal#128.
* Stop doing O(n^2) work to find event's home (`eventShouldLiveIn`) ([\matrix-org#3227](matrix-org#3227)). Contributed by @jryans.
* Fix bug where video would not unmute if it started muted ([\matrix-org#3213](matrix-org#3213)). Fixes element-hq/element-call#925.
* Fixes to event encryption in the Rust Crypto implementation ([\matrix-org#3202](matrix-org#3202)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GYU: Implement MSC3952 in matrix-js-sdk
2 participants